Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update threshold of watchdog testnet canister #295

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: update threshold of watchdog testnet canister #295

merged 1 commit into from
Apr 30, 2024

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Apr 29, 2024

With recent block surges it's becoming more common for the bitcoin testnet to be ahead of external block explorers. To avoid disabling the bitcoin testnet API for extended periods of time, this commit makes the watchdog less sensitive to differences in height between the bitcoin testnet canister and external explorers, making it less likely for it to disable the Bitcoin API for developers.

@ielashi ielashi requested a review from a team as a code owner April 29, 2024 13:00
@github-actions GitHub Actions
Copy link

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (-0.00%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (-0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (-0.00%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@ielashi ielashi merged commit c3ee79b into master Apr 30, 2024
25 checks passed
@ielashi ielashi deleted the ielashi/update_watchdog branch April 30, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsarlis dsarlis dsarlis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ielashi @dsarlis